Feature flags - #9
Merged
Merged
Conversation
yakkomajuri
force-pushed
the
feature-flags
branch
from
September 14, 2020 09:37
44dfadb to
5e70ca8
Compare
yakkomajuri
approved these changes
Sep 14, 2020
yakkomajuri
left a comment
yakkomajuri
left a comment
Contributor
There was a problem hiding this comment.
@timgl I made some minor changes but otherwise this looks good to me. See if the changes make sense and otherwise feel free to merge
Contributor
|
@timgl following up here |
Contributor
Author
|
One thing I should really add is a timeout for the call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8 should be merged in first